custom app crashes when run in new drawing

[cmccartney]

So I'm novice at .NET and have written an app that loads a windows form, inserts several blocks depending on button click, rotates them then counts them up. it seems to be working fine. The occasional problem is when i start or open up a different drawing, running the app (always running from command line) will cause autocad to crash. Now if i go back in and open up the drawing it crashed on, it works fine and then may work on a second drawing fine. So questions, has anyone else experienced this? Is this due to the app being still resident after the first run? Am i missing some code when i hit the exit button to clear it out? (im guessing here) Anyways the code is attached for those that would like to look at it. Oh and im running in C3D 2011, compiled in .NET Framework 4.

[BlackBox]

Firstly, I am new to .NET myself... But this line from your post jumps out to me:

Oh and im running in C3D 2011, compiled in .NET Framework 4.

2011 products are .NET 3.5, 2012 & 2013 are .NET 4.0, and 2014 is expected to be .NET 4.5.

Open your project, and change it to compile to .NET 3.5, then rebuild the binary (you'll probably need to close the project, and reopen first).

HTH

[cmccartney]

Hrmm interesting i was able to run it at all under 4, howerver recompling under 3.5 did not help.

[BlackBox]

I've downloaded the ZIP file you posted, and will try to look it over tonight after work.

[cmccartney]

i forgot the source block file, you will need this to test

[BlackBox]

i forgot the source block file, you will need this to test

... Got it.

[fixo]

At the quick glance I see the main reason to crash your application.
If you use code block " Using... End Using" you do not have never to
dispose this object, e.g.

Using tr as Transaction=...
remove from there: tr.Dispose()
End using

Same way for all other objects in similar code blocks
Hope this helps,

~'J'~

[cmccartney]

hrmm i see what your saying, but does not fix the problem. i just went four drawings then crash, restarted then crashed on second drawing again sheesh.

[cmccartney]

oookay after playing with the code some more i think i solved it, now going on ten coninous drawings started or opened through various methods, no crashes.
This was the bugger in question:

Blockname = Nothing

wierd right? i was trying to clear the variable before my next button click, this along with the tr.dipose that i got rid of seems to have fixed it. (Also re-wrote the layer checking section)
Here's the new code for anyone who wants to take a look.
so color this post solved!