Coding help

[cadd4la]

Hello everyone,

I need a little help to get this code to work.

Thanks,

(DEFUN C:PLC2P(/ *error* useros usercmd)
;; error function & Routine Exit
   (DEFUN *error* (msg)
     (IF
       (NOT
     (MEMBER
       msg
       '("console break"
         "Function cancelled"
         "quit / exit abort"
         ""
        )
     ) ;_ end of member
       ) ;_ end of not
        (PRINC (STRCAT "nError: " msg))
     ); endif
     ;;reset all variables here
     (IF    useros
       (SETVAR "osmode" useros)
     ) ;_ end of if
     (IF    usercmd
       (SETVAR "CMDECHO" usercmd)
     ) ;_ end of if
     (SETQ useros nil
       usercmd nil
     ) ;_ end of setq
   );end error function  (defun *Error* (msg) ; embedded defun
 
   (SETQ    useros    (GETVAR "osmode")
     usercmd    (GETVAR "CMDECHO")
   ) ;_ end of setq
(SETVAR "CMDECHO" 0)
(SETQ os1 (GETVAR "osmode"))
(princ "\nPLINE FROM CENTER TO PERPENDICULAR:")    
;;(setq ossnap (getvar "osmode"))
        
(SETVAR "OSMODE" 4);;
<--- CENTER OSNAP       
(SETQ PT1 (GETPOINT "PICK FIRST POINT"))
        
(SETVAR "OSMODE" 128)
;;
<--- PERPENDICULAR OSNAP        
(SETQ PT2 (GETPOINT PT1 "PICK SECOND POINT"))
        
(SETVAR "OSMODE" 0)
           
(COMMAND "_PLINE" PT1 "perp" PT2 )
    
;;(setvar "osmode" ossnap)

(SETVAR "osmode" os1)
(SETVAR "CMDECHO" 1)        
(princ)

 ) ;_ end of DEFUN

[pbejse]

Theres, nothing wrong with the code itself. except where you place the comments

(SETVAR "OSMODE" 4);; <--- CENTER OSNAP       
(SETQ PT1 (GETPOINT "PICK FIRST POINT"))
        
(SETVAR "OSMODE" 128)
;; <--- PERPENDICULAR OSNAP

[BlackBox]

Compare this:

(defun c:FOO1 ()
  (command "._pline" "_cen" pause "_perp" pause "")
  (princ)
)

... To this:

(vl-load-com)

(defun c:FOO2 (/ *error* startPoint endPoint oldCmdecho oldOsmode)

  (defun *error* (msg)
    (and oldCmdecho (setvar 'cmdecho oldCmdecho))
    (and oldOsmode (setvar 'osmode oldOsmode))
    (cond ((not msg))                                                   ; Normal exit
          ((member msg '("Function cancelled" "quit / exit abort")))    ; <esc> or (quit)
          ((princ (strcat "\n** Error: " msg " ** ")))                  ; Fatal error, display it
    )
    (princ)
  )

  (if
    (and
      (setq oldOsmode (getvar 'osmode))
      (setvar 'osmode 4)
      (setq startPoint (getpoint "\nSpecify first point: "))
      (setvar 'osmode 128)
      (not (initget 32))
      (setq endPoint (getpoint startPoint "\nSpecify second point: "))
    )
     (progn
       (setq oldCmdecho (getvar 'cmdecho))
       (setvar 'cmdecho 0)
       (command "._pline" "_non" startPoint "_perp" endPoint "")
     )
  )
  (*error* nil)
)

[BlackBox]

Theres, nothing wrong with the code itself. except where you place the comments

Tisk, tisk, pbejse... Consider pt1 == Nil

[pbejse]

Tisk, tisk, pbejse... Consider pt1 == Nil

Of course BlackBox... just point out the obvious error and most probably the reason why it doesn't work for cadd4l at all.

But you're right... been lazy this past few days to even suggest the proper coding habits.

Thank you nevertheless for pointing that out... I deservedit i guess

Cheers

[BlackBox]

Of course BlackBox... just point out the obvious error and most probably the reason why it doesn't work for cadd4l at all.

But you're right... been lazy this past few days to even suggest the proper coding habits.

Thank you nevertheless for pointing that out... I deservedit i guess

Cheers

I'm only ribbing you, because you have much knowledge.

[pbejse]

I'm only ribbing you, because you have much knowledge.

Thank you BlackBox. None taken. I've been busy brushing up on my 3D and rendering skills this past few weeks since i contracted a small project that requires that set of skills.

cheers

[BlackBox]

Thank you BlackBox. None taken. I've been busy brushing up on my 3D and rendering skills this past few weeks since i contracted a small project that requires that set of skills.

cheers

We'll have to chat elsewhere... My background is actually in Computer Animation using Maya; character modeling, texturing, lighting, rigging, animating, rendering, etc..

/OffTopic

[cadd4la]

BlackBox,

Thanks for the help, but the code is not resetting if I click on the ESC key.

[BlackBox]

... the code is not resetting if I click on the ESC key.

It works just fine on my end... What is not resetting, exactly?