Error Trap issue

[cadconcepts]

Hi All
I have an error trap that I have been using for years and I recently notice that it was not really working correctly. When I purposely cause an error I get the following message:
Undoing. . .
Cannot invoke (command) from *error* without prior call to (*push-error-using-command*).
Converting (command) calls to (command-s) is recommended.

I typically add the top of all of my function (CM:ERR) which is loaded in my toolbox of functions. I am setting cm_undo_it within the routine I am having trouble with. Any help is greatly appreciated.

Manuel

(defun CM:ERR ()
   (if (null *debug*)
     (progn
       (setq errfun *error*)
       (defun *ERROR* (msg)(sys_err msg))
     )
     (setq *error* nil)
   )
(princ)
)
(defun sys_err (errmsg /)
   (if errfun (setq *error* errfun errfun nil))
   (while (> (getvar "CMDACTIVE") 0)(command)) ;_  end while
   (if (and errmsg (null (member errmsg '("Function cancelled" "quit / exit abort"))))
     (princ (strcat "\n** Error: " errmsg " ** "))
   )
   (if cm_undo_it
     (progn
       (princ "\nUndoing. . . ")
       (command ".undo" "end" ".undo" 1)
       (setq cm_undo_it nil)
     )
     (vla-EndUndoMark (vla-get-activedocument (vlax-get-acad-object))) ;modified 1-22-09
   )
   (CM:MODER) 
)

[Tom Beauford]

Looks complicated, do you really need to use (command) to cancel active commands? Ever consider using *ERROR* as a local variable? I never modify *ERROR* globally. You need to update those toolbox functions, (command-s) was added in 2012.

[BlackBox]

I too used a generic 'toolbox' error trap, and found it to be too cumbersome, and hard to make 'custom' for any given routine, which ultimately ends up functioning just like the native error trap, which doesn't have the subsequent requirement of first storing, then restoring, etc, nor any of the implicit dependencies.

I later learned the value of localizing *error* within the Defun, which allowed me complete autonomy to be able to handle each routine's needs... A bit more duplication of code, but it's easier to maintain, isn't dependent on other 'toolbox' functions, and is more portable to distribute to others in-house as well as in forums, etc.

Cheers

[peter]

I stopped using the *Error* method for trapping errors in favor of full error handling like try catch in .net. Using the standard errortrap function i can pass almost any function to it and trap the error to any line of code or any sub/function.

This allows for on error resume next functionality that doesn't stop the routine if an error is encountered.

P=

[Raudel Hinojosa Sr]

Did you ever get a solution for this. Am having the same issue.

Raudel Hinojosa