Update Title Block Lisp Problem

[stusic]

Good Afternoon!

I have a lisp that I use to update our title blocks. I'm trying to add a way to update each layout with the correct rev level (that I'm getting through an sql query). I've got just about everything, but I can't figure out how to update each page's attribute with the correct rev level Can someone show me how to update these? I appreciate any help

This is what I use to get the rev level:

(if
    (and
      (setq
        ss (ssget "_x" '((0 . "INSERT") (2 . "*BORDER*") (66 . 1)))
      )
    )
     (progn


       ;; Get page_no attribute values from blocks
       (vlax-for x (setq ss (setq acDoc
                                   (vla-get-activeselectionset
                                     (vla-get-activedocument
                                       (vlax-get-acad-object)
                                     )
                                   )
                            )
                   )
         (foreach att (vlax-invoke x 'getattributes)
           (if (= "PAGE_NO" (vla-get-tagstring att))
             (progn
               (setq pageNo (atoi (vla-get-textstring att)))
               (setq data (cons (cons x pageNo) data))
             )
           )
         )
       )


;; Put revision attribute values into blocks - separated out because elvis has page numbers and descriptions as one record in his db. derp.
(foreach item data


;;; for drawings that can have more than one page number
(cond
  ((or
     (= abb "PD")
     (= abb "WD")
     (= abb "CHL"))
   (setq fld11	(strcat "SELECT level FROM revisions WHERE (item LIKE '%"fld1"%') AND (document = '"fld7">pg "(vl-princ-to-string (cdr item))"') ORDER BY level DESC")))


;;; for drawings that only have one page  
  ((or
     (= abb "HL")
     (= abb "CL")
     (= abb "LP"))
   (setq fld11 (strcat "SELECT level FROM revisions WHERE (item LIKE '%"fld1"%') AND (document = '"fld7"') ORDER BY level DESC")))


;;; for drawings with various numbers after the drawing name (ks1, ks2, ks3, etc.)  
  ((or
     (= abb "KS")
     (= abb "KE")
     (= abb "KM"))
   (setq fld11	(strcat "SELECT level FROM revisions WHERE (item LIKE '%"fld1"%') AND (document = '"abb">"abb2"') ORDER BY level DESC")))
  )	; end cond
  
;;;
	 
         (if (setq
	       adoValue	(caadr (ADOLISP_DoSQL ConnectionObject fld11))
	     )
	   (foreach att	(vlax-invoke (car item) 'getattributes)
	     (if (= "REV" (vla-get-tagstring att))
	       (if (/= nil adoValue)
		 (and
		   (prompt (strcat "\nPage No: " (vl-princ-to-string (cdr item)) ", " "Rev No: " (itoa adoValue)))(princ)
		   (vla-put-textstring att adoValue))
                   ;;  somewhere in here is where I believe i need to update the block, but I don't know how <sad panda face>
		 (vla-put-textstring att 0)
	       )
	     )
	   )
	 )
       )
       (*error* nil)
     )
  )

[stusic]

Additionally, the

(prompt (strcat "\nPage No: " (vl-princ-to-string (cdr item)) ", " "Rev No: " (itoa adoValue)))(princ)

is getting the information like it should, just don't know why

(vla-put-textstring att adoValue))

isn't working like (I think) it should.

2015-05-22_1607.png

[dgorsman]

What's the data type of the TextString property? What data type are you trying to push into it?

[stusic]

The textstring variable att is a attribute value (a number or nil, maybe stored as a string?) and I'm trying to send it a string (adoValue). Does that help?

[dgorsman]

Are you certain? Check your (prompt ...) call - you are using (itoa adoValue) while your (vla-put-TextString ...) call does not. Have a look at the data type on the TextString property documentation

[stusic]

Weird. Left Friday and my code was iterating through all the page numbers and retrieving all the correct revision levels; today, it's just bringing back the page number for whatever the curretn layout is and bringing back the revision level for that page.

So this:

(vlax-for x (setq ss (setq acDoc
                                   (vla-get-activeselectionset
                                     (vla-get-activedocument
                                       (vlax-get-acad-object)
                                     )
                                   )
                            )
                   )
         (foreach att (vlax-invoke x 'getattributes)
           (if (= "PAGE_NO" (vla-get-tagstring att))
             (progn
               (setq pageNo (atoi (vla-get-textstring att)))
               (setq data (cons (cons x pageNo) data))
             )
           )
         )
       )

is bringing back this:
2015-05-26_1019.png

Then if I change layouts, I get odd results (not just for the current page as a bove, but ofr the curretn page, other pages, page 6 repeated 4 times, etc). So even before I try and get the right data type, I need to make sure I'm running through the blocks correctly. I don't know why this doesn't work anymore... From my Watch list, it appears to be iterating through the blocks correctly (each vla-object has a different handle), but it's still returning incorrect page numbers. Wtf.

[stusic]

2015-05-26_1253.png

Why in the world would it be grabbing these attributes from these seemingly random order of blocks? Shouldn't it iterate through each one? I mean, it repeats some goes to others, doesn't get all of them... Grr.

[stusic]

If I just open the drawing and run the program, it will iterate through 10 blocks (there are 10 drawings, this block is in the title block in paperspace), but will list whichever layout I'm on 10 times. If I change to another layout, then run the routine again, it'll add that to the selection set (still only iterating through 10 blocks, but will replace one of them with the new tab block. If I activate each layout tab, then it will add those to the selection set. I don't understand.

[stusic]

Okay, I fixed the problem with the attributes not updating properly (becuase I'm dumb and used "and" instead of the "progn" I should have), but I still can't figure out this weird "we're not going to count it as a part of the selection set unless you activate the layout tab" debacle.

For reference, here's my code that looks alright to me:

(if
    (and
      (setq
        ss (ssget "_x" '((0 . "INSERT") (2 . "*BORDER*") (66 . 1)))
      )
    )
     (progn


       ;; Get page_no attribute values from blocks
       (vlax-for x (setq ss (setq acDoc
                                   (vla-get-activeselectionset
                                     (vla-get-activedocument
                                       (vlax-get-acad-object)
                                     )
                                   )
                            )
                   )
         (foreach att (vlax-invoke x 'getattributes)
           (if (= "PAGE_NO" (vla-get-tagstring att))
             (progn
               (setq pageNo (atoi (vla-get-textstring att)))
               (setq data (cons (cons x pageNo) data))
             )
           )
         )
       )


;; Put revision attribute values into blocks - separated out because elvis has page numbers and descriptions as one record in his db. derp.
(foreach item data


;;; for drawings that can have more than one page number
(cond
  ((or
     (= abb "PD")
     (= abb "WD")
     (= abb "CHL"))
   (setq fld11	(strcat "SELECT level FROM revisions WHERE (item LIKE '%"fld1"%') AND (document = '"fld7">pg "(vl-princ-to-string (cdr item))"') ORDER BY level DESC")))


;;; for drawings that only have one page  
  ((or
     (= abb "HL")
     (= abb "CL")
     (= abb "LP"))
   (setq fld11 (strcat "SELECT level FROM revisions WHERE (item LIKE '%"fld1"%') AND (document = '"fld7"') ORDER BY level DESC")))


;;; for drawings with various numbers after the drawing name (ks1, ks2, ks3, etc.)  
  ((or
     (= abb "KS")
     (= abb "KE")
     (= abb "KM"))
   (setq fld11	(strcat "SELECT level FROM revisions WHERE (item LIKE '%"fld1"%') AND (document = '"abb">"abb2"') ORDER BY level DESC")))
  )	; end cond
  
;;;
	 
         (if (setq
	       adoValue	(caadr (ADOLISP_DoSQL ConnectionObject fld11))
	     )
	   (foreach att	(vlax-invoke (car item) 'getattributes)
	     (if (= "REV" (vla-get-tagstring att))
	       (if (/= nil adoValue)
		 (progn
		   (prompt (strcat "\nPage No: " (vl-princ-to-string (cdr item)) ", " "Rev No: " (itoa adoValue)))(princ)
		   (vla-put-textstring att adoValue))
		 (vla-put-textstring att 0)
	       )
	     )
	   )
	 )
       )
       (*error* nil)
     )
  )

[peter]

Can you share an example drawing with the layouts set up the way you need them...

Maybe show a finished version too.

I would avoid using the selection set method... IMHO

Iterate through the layouts collection and iterate through the items in the block (objects) collection looking for AcDbBlockReferences.

Check the effective names.

etc...

I can play with it if you post them.