Repeat command until it is cancelled

[ccowgill]

I want this command to repeat until it is canceled. It currently does that, when the escape key is used, but if the enter key or space bar is used instead of selecting a point, it spits back this error.

Error: bad argument type: numberp: nil

the program works fine, I just want the error message to go away

;;===============================================
;;		 L o c a l   F u n c t i o n s		 
;;===============================================
;; error function & Routine Exit
(defun *error* (msg)
  (if
	(not
	  (member
 msg
 '("console break"
   "Function cancelled"
   "quit / exit abort"
   ""
  )
	  )
	)
	 (princ (strcat "nError: " msg))
  )	 ; endif
  (restore_sys_vars)   ; reset vars
)
 
;; Function to save system variables in global variable
;;  call to function
;;  (save_sys_vars '("CMDECHO" "CLAYER" "OSMODE" "CECOLOR"))
(defun save_sys_vars (lst)
  (setq *sysvarlist* '())
  (repeat (length lst)
	(setq *sysvarlist*
	(append *sysvarlist*
	 (list (list (car lst) (getvar (car lst))))
	)
	)
	(setq lst (cdr lst))
  )
)
;; Function to reset system variables 
(defun restore_sys_vars ()
  (repeat (length *sysvarlist*)
	(setvar (caar *sysvarlist*) (cadar *sysvarlist*))
	(setq *sysvarlist* (cdr *sysvarlist*))
  )
)
(save_sys_vars
  '("CMDECHO" "OSMODE" "CECOLOR" "CLAYER" "PICKBOX" "TEXTSTYLE")
)
	 ;GET SYSTEM VAR & error handling
	 ;SET SYSTEM VAR
(defun c:ca (/ ss elev th textobj)
  (setvar "cmdecho" 0)
  (setvar "osmode" 512)
  (setq ss (getpoint "Select Contourn")
 elev (rtos (caddr ss))
 th (* 0.06 40)
 textobj (vla-addtext acadModelSpace elev (vlax-3d-point ss) TH)
  )
  (vla-put-alignment textobj 10)
  (vla-put-textalignmentpoint textobj (vlax-3d-point ss))
  (c:ca)
  (*error* "")	;RESTORE SYSTEM VAR
  (princ)
)	 ;end defun

any help would be appreciated

[ccowgill]

I removed the error message by making the changes in red, but if there are other errors, they probably wont show messages either.

(defun *error* (msg)
;| (if
(not
(member
msg
'("console break"
"Function cancelled"
"quit / exit abort"
""
)
)
)
(princ (strcat "nError: " msg))
) ; endif
|; (restore_sys_vars) ; reset vars
)

if someone could point me in the direction of removing the message when just enter or space is used to exit the command it would be appreciated

[Opie]

(defun c:ca (/ ss elev th textobj)
  (setvar "cmdecho" 0)
  (setvar "osmode" 512)
  (setq ss (getpoint "Select Contourn"))
  (if ss
    (progn
  (setq elev (rtos (caddr ss))
 th (* 0.06 40)
 textobj (vla-addtext acadModelSpace elev (vlax-3d-point ss) TH)
  )
  (vla-put-alignment textobj 10)
  (vla-put-textalignmentpoint textobj (vlax-3d-point ss))
    )
  )
  (c:ca)
  (*error* "")	;RESTORE SYSTEM VAR
  (princ)
)	 ;end defun

You need to verify ss as a point. The if statement above should help. I have not tested it.

[jwanstaett]

try this
The error is do to ss = nil if you do not select a point. The change use ss=nil to exit the while fuction.

;;===============================================
;; L o c a l F u n c t i o n s 
;;===============================================
;; error function & Routine Exit
(defun *error* (msg)
(if
	(not
	 (member
msg
'("console break"
"Function cancelled"
"quit / exit abort"
""
)
	 ) ;_ end of member
	) ;_ end of not
	 (princ (strcat "nError: " msg))
)	 ; endif
(restore_sys_vars) ; reset vars
) ;_ end of defun
;; Function to save system variables in global variable
;; call to function
;; (save_sys_vars '("CMDECHO" "CLAYER" "OSMODE" "CECOLOR"))
(defun save_sys_vars (lst)
(setq *sysvarlist* '())
(repeat (length lst)
	(setq *sysvarlist*
	(append *sysvarlist*
	 (list (list (car lst) (getvar (car lst))))
	) ;_ end of append
	) ;_ end of setq
	(setq lst (cdr lst))
) ;_ end of repeat
) ;_ end of defun
;; Function to reset system variables 
(defun restore_sys_vars ()
(repeat (length *sysvarlist*)
	(setvar (caar *sysvarlist*) (cadar *sysvarlist*))
	(setq *sysvarlist* (cdr *sysvarlist*))
) ;_ end of repeat
) ;_ end of defun
(save_sys_vars
'("CMDECHO" "OSMODE" "CECOLOR" "CLAYER" "PICKBOX" "TEXTSTYLE")
) ;_ end of save_sys_vars
	 ;GET SYSTEM VAR & error handling
	 ;SET SYSTEM VAR
(defun c:ca (/ ss elev th textobj)
(setvar "cmdecho" 0)
(setvar "osmode" 512)
(setq ss (getpoint "Select Contourn"))
(while (/= ss nil)
	(setq elev (rtos (caddr ss))
th (* 0.06 40)
textobj (vla-addtext acadModelSpace elev (vlax-3d-point ss) TH)
	) ;_ end of setq
	(vla-put-alignment textobj 10)
	(vla-put-textalignmentpoint textobj (vlax-3d-point ss))
	(setq ss (getpoint "Select Contourn"))
) ;_ end of while
(*error* "")	;RESTORE SYSTEM VAR
(princ)
)

[jwanstaett]

change added the code to set acadModelSpace so it would work. you must be set acadModelSpace some place.

 ;;===============================================
;;   L o c a l   F u n c t i o n s   
;;===============================================
;; error function & Routine Exit
(defun *error* (msg)
  (if
	(not
	  (member
 msg
 '("console break"
   "Function cancelled"
   "quit / exit abort"
   ""
  )
	  ) ;_ end of member
	) ;_ end of not
	 (princ (strcat "nError: " msg))
  )	 ; endif
  (restore_sys_vars)   ; reset vars
) ;_ end of defun
(setq acadModelSpace
	   (VLA-GET-MODELSPACE
  (VLA-GET-ACTIVEDOCUMENT (vlax-get-acad-object))
	   ) ;_ end of VLA-GET-MODELSPACE
) ;_ end of setq
;; Function to save system variables in global variable
;;  call to function
;;  (save_sys_vars '("CMDECHO" "CLAYER" "OSMODE" "CECOLOR"))
(defun save_sys_vars (lst)
  (setq *sysvarlist* '())
  (repeat (length lst)
	(setq *sysvarlist*
	(append *sysvarlist*
	 (list (list (car lst) (getvar (car lst))))
	) ;_ end of append
	) ;_ end of setq
	(setq lst (cdr lst))
  ) ;_ end of repeat
) ;_ end of defun
;; Function to reset system variables 
(defun restore_sys_vars ()
  (repeat (length *sysvarlist*)
	(setvar (caar *sysvarlist*) (cadar *sysvarlist*))
	(setq *sysvarlist* (cdr *sysvarlist*))
  ) ;_ end of repeat
) ;_ end of defun
(save_sys_vars
  '("CMDECHO" "OSMODE" "CECOLOR" "CLAYER" "PICKBOX" "TEXTSTYLE")
) ;_ end of save_sys_vars
	 ;GET SYSTEM VAR & error handling
	 ;SET SYSTEM VAR
(defun c:ca (/ ss elev th textobj)
  (setvar "cmdecho" 0)
  (setvar "osmode" 512)
  (setq ss (getpoint "\nSelect Contourn"))
  (while (/= ss nil)
	(setq elev   (rtos (caddr ss))
   th   (* 0.06 40)
   textobj (vla-addtext acadModelSpace elev (vlax-3d-point ss) TH)
	) ;_ end of setq
	(vla-put-alignment textobj 10)
	(vla-put-textalignmentpoint textobj (vlax-3d-point ss))
	(setq ss (getpoint "\nSelect Next Contourn"))
  ) ;_ end of while
  (*error* "")	;RESTORE SYSTEM VAR
  (princ)
)	 ;end defun

[ccowgill]

sorry about that, acadModelSpace is defined in my main lisp program (the one that loads all my routines)

Opie, yours suggestion worked fine other than:

(vla-put-textalignmentpoint textobj (vlax-3d-point ss))
  (c:ca)
);end progn
);end if

the two ) need to be after c:ca

[Opie]

Does it repeat if you do that? It's your program. Enjoy.

[ccowgill]

yes, it operates as intended, thanks for your help