The Autodesk Revit Model Content Style Guide, on page 25, specifies that file names should not include spaces.
I disagree. I think the only reason for that is to avoid weird looking hyperlinks if you happen to host the family on Seek or some other web portal.
Is there some other reason to avoid spaces of which I am unaware? (It cannot be a external database issue since most modern db permit spaces.)