foreach lay NOT in layerlist

[mruu88781911]

Is there a simple way to invert the line (foreach lay laylist ?

I assumed/hoped it would be as simple as writing something like (foreach lay / laylist


But that didn't work and I can't seem to find the correct way of writing something like that..

Cheers

[BlackBox]

Perhaps it would help (us help you) if you post what you're actually trying to do?

(LayoutList) contains all Layouts in a given drawing; you don't need to iterate Model, as it is the only non-Layout tab in same.

Cheers

[mruu88781911]

Mm.. ok admittedly there are a couple of things wrong with with my code (that i can tell):

What I'm trying to do is find all the xrefs that are on layers NOT specified in my given list, and create a list of those xrefs (we want to know if xrefs are existing on layers that they're not suppose to be on).

So I had a feeling I couldn't just say (foreach lay NOT in laylist like i asked initially, & instead I'm now creating a list of ALL layers ("layall"), & subtracting my specified list of layers ("laylist1") to create a list of remaining layers for me to check if xrefs are existing on ("laylist2").

;; ATTEMPT 2 - Working thorugh reverse layer list and if xrefs then add to list

(defun C:getxref (/ laylist1 layall laylist2 xrlist activedocument theblocks yesxref ablock)

		(setq laylist1 '("XREF-IMG-FRT"  						;establish laylist1	
						"XREF"
						"XREF-IMG-BCK"
						);end_laylist
		);end_setq

(vlax-for lyr											;establish layall (all layers)
	(vla-get-layers (vla-get-activedocument (vlax-get-acad-object)))
	(setq layall (cons (vla-get-name lyr) layall))
)																		

;(vl-remove pi (list pi t 0 "abc"))
(setq laylist2 (vl-remove laylist1 (layall)))							;subtract laylist1 from layall to get laylist2		X)faulty

(foreach lay laylist2 													
	(vl-load-com)
	(setq activedocument (vla-get-activedocument (vlax-get-Acad-Object)))
	(setq theblocks (vla-get-blocks activedocument))					;this needs to be get-block from current layer/"lay"         X)faulty
	(setq xrlist '())													
	(vlax-for item theblocks
		(setq yesxref (vlax-get-property item 'isXref))

		(if (= yesxref :vlax-true)							;if the block is xref								

			(progn
				(setq ablock (vlax-get-property item 'Name))
				(setq xrlist (append (list ablock) xrlist))			;establish xrlist - list of xrefs on layers belonging to laylist2
			);progn

		);if
	);vlax-for
);foreach
(princ xrlist)
);defun

I've marked the lines which I've identified as not working how I'd like it to.

[mruu88781911]

I solved the first part!!

;(vl-remove pi (list pi t 0 "abc"))
(setq laylist2 (vl-remove laylist1 (layall)))							;subtract laylist1 from layall to get laylist2		X)faulty

becomes:

(setq laylist2 (car (vl-remove laylist1 (list laylist1 layall))))
(foreach x laylist1 (setq laylist2 (vl-remove x laylist2)))

[mruu88781911]

So the last piece I'm having trouble with is here:

(foreach lay laylist2 													
	(vl-load-com)
	(setq activedocument (vla-get-activedocument (vlax-get-Acad-Object)))
	(setq theblocks (vla-get-blocks activedocument))					;this needs to be: get-block on current layer/"lay"			X)faulty
	(setq xrlist '())													
	(vlax-for item theblocks
		(setq yesxref (vlax-get-property item 'isXref))
		(if (= yesxref :vlax-true)				
			(progn
				(setq ablock (vlax-get-property item 'Name))
				(setq xrlist (append (list ablock) xrlist))			;establish xrlist - list of xrefs on layers belonging to laylist2
			);progn
		);if
	);vlax-for
);foreach

At the moment it's getting all blocks in the whole active document, but I want it to be getting only the blocks on each "lay"(layers in laylist2)..
And then if those are xrefs, add them to the list: xrlist.

So something like this??

(setq activedocument (vla-get-activedocument lay (vlax-get-Acad-Object)))
(setq theblocks (vla-get-blocks activedocument))

[BIG-AL]

Just a side issue "item" is a word used in VL functions maybe call it something else in your code like xitem

[BlackBox]

Perhaps it would be simpler to iterate Blocks to test for IsXref, then if a valid selection set for XREFs exists, iterate the selection to test for invalid Layer & simply return the list:

(vl-load-com)

(defun _GetXrefsNotOn (layers / *error* xrefs ss name)
  ;; Example:
  ;; (_GetXrefsNotOn '("XREF-IMG-FRT" "XREF" "XREF-IMG-BCK"))

  (defun *error* (msg)
    (if ss (vla-delete ss))
    (cond ((not msg))                                                   ; Normal exit
          ((member msg '("Function cancelled" "quit / exit abort")))    ; <esc> or (quit)
          ((princ (strcat "\n** Error: " msg " ** ")))                  ; Fatal error, display it
    )
    xrefs
  )
  
  (vlax-for x (vla-get-blocks
                (setq acDoc (vla-get-activedocument (vlax-get-acad-object)))
              )
    (if (= :vlax-true (vla-get-isxref x))
      (setq xrefs (cons (vla-get-name x) xrefs))
    )
  )
  (if
    (ssget
      "_x"
      (list
        '(0 . "INSERT")
        (cons
          2
          (vl-string-right-trim
            ","
            (apply
              'strcat
              (mapcar
                (function (lambda (x) (strcat x ",")))
                xrefs
              )
            )
          )
        )
        '(410 . "Model")
      )
    )
     (progn
       (setq xrefs nil)
       (vlax-for x (setq ss (vla-get-activeselectionset acDoc))
         (if
           (and
             (not (vl-position (vla-get-layer x) layers))
             (not (vl-position (setq name (vla-get-name x)) xrefs))
           )
           (setq xrefs (cons name xrefs))
         )
       )
     )
  )
  
  (*error* nil)
)

[mruu88781911]

Sorry... I'm a little confused. How does it know which are the right and wrong layers for all xrefs to be on? Where have you input the list of correct layers?

[mruu88781911]

I think i've made it work... I had to enter the list in myself right?

Also, could you tell me what the line in bold is doing here?

         (if
           (and
             (not (vl-position (vla-get-layer x) laylist1))
             (not (vl-position (setq name (vla-get-name x)) xrefs))

I understand the other one is saying "if not on any layers from the given layer list", but what is the following if for?

Thanks

[BlackBox]

Sorry... I'm a little confused. How does it know which are the right and wrong layers for all xrefs to be on? Where have you input the list of correct layers?

The sub-function above requires a single argument - a list of layer names - which allows you (or anyone else) to define the appropriate list, as shown in the commented 'example'.

I think i've made it work... I had to enter the list in myself right?

Also, could you tell me what the line in bold is doing here?

         (if
           (and
             (not (vl-position (vla-get-layer x) laylist1))
             (not (vl-position (setq name (vla-get-name x)) xrefs))

I understand the other one is saying "if not on any layers from the given layer list", but what is the following if for?

The second test expression you've bolded is to preclude duplicates from being added to the list of XREFs.

Cheers