Brick Jack Arch Lisp Help

[BCrouse]

Please look at this lisp and help me out trying to get past the third command. Also, I was wondering if there could be a function that makes the drawing that was created a block and name it pertaining to the type of Brick Jack Arch, length and send it to a file ? See examples for names

4cK-45.5.dwg

4c = 4 course high brick
K = keystone
45.5 = length

_________

3cK-45.5.dwg

3c = 3 course high brick
K=keystone
45.5 = length
___________

4c-45.5.dwg

4c = 4 course high brick
45.5 = length

_________

3c-45.5.dwg

3c = 3 course high brick
45.5 = length



Thank you,

Brad

[lance.81922]

Brad -- You need to learn how to step through your program with the debugger. Your initial error is in your DTR function. AutoLISP knows pi as PI -- not as #p or #P. Fix that and then continue. If you don't know how to step through, go to the VisualLISP window, pick the Debug menu, and click on Stop Once. Then go ahead and load your program and watch what happens.

[BCrouse]

Brad -- You need to learn how to step through your program with the debugger. Your initial error is in your DTR function. AutoLISP knows pi as PI -- not as #p or #P. Fix that and then continue. If you don't know how to step through, go to the VisualLISP window, pick the Debug menu, and click on Stop Once. Then go ahead and load your program and watch what happens.

Thank you for your help Lance. I really appreciate it.

Thank you,

Brad

[BCrouse]

Brad -- You need to learn how to step through your program with the debugger. Your initial error is in your DTR function. AutoLISP knows pi as PI -- not as #p or #P. Fix that and then continue. If you don't know how to step through, go to the VisualLISP window, pick the Debug menu, and click on Stop Once. Then go ahead and load your program and watch what happens.

I changed the #p or P# to be PI the the lisp. When debugging it gets hung up @ the following areas .

 
 ;;define DEGREE to RADIAN function
(defun DTR (X)  (/ (* X PI) 180.0) ;_MULTIPLY THE  DGR ING BY PI  AND DIVIDE IT BY 180
) ;_end dtr

and this area:

  
(defun calculus ()
  (setq ang-arch 24)
  (setq #ang-arch (dtr ang-arch))
  (setq #ang-arch/2 (/ #ang-arch 2))
  (setq left-ang (+ PI90 #ang-arch/2))
  (setq right-ang (- PI90 #ang-arch/2))
;;(4C-cal)
;;(3c-cal)  
) ;_end defun (calculus)

Why is the PI causing ti hang up?

Thank you,

Brad

[CAB2k]

you must seperate the / with a space #ang-arch/2 in not the same as #ang-arch / 2

the DTR function looks ok, what line of code is calling it? is the item passes a number?

[scwegner]

you must seperate the / with a space #ang-arch/2 in not the same as #ang-arch / 2

the DTR function looks ok, what line of code is calling it? is the item passes a number?

You're right, they're not the same. But he's not trying for that. #ang-arch/2 is his variable name (albeit a complicated one). #ang-arch / 2 is invalid syntax and would cause an error. DTR is called in the third line of the second defun.

I didn't see anything wrong with DTR and it worked fine when I tried it. Why are you convinced the pi is still causing the problem. What's PI90? Starting at the beginning with jack-archs it goes to user-data and then to calculus without having defined any variable called PI90. In fact, I didn't see it defined anywhere in the file.

A few side notes (and these are stylistic so obviously a personal preference):
There's no need for so many setqs you can clean it up a little like this

  (defun calculus    ()
  
    (setq ang-arch 24)
            #ang-arch (dtr ang-arch)
            #ang-arch/2 (/ #ang-arch 2)
            left-ang (+ #p90 #ang-arch/2)
            right-ang (- #p90 #ang-arch/2)
    );setq
  ;;(4C-cal)
  ;;(3c-cal)  
  
  ) ;_end defun (calculus)

Not a big difference there, but over the course of a huge program like that it helps group things and saves a lot of typing.
Second, is there a method to the madness as far as the order of your subroutines? I couldn't see one and with so many, it's helpful to have them sorted somehow.

[CAB2k]

You're right, they're not the same. But he's not trying for that. #ang-arch/2 is his variable name (albeit a complicated one). #ang-arch / 2 is invalid syntax and would cause an error.

Ooops, I should pay more attention.

[BCrouse]

You're right, they're not the same. But he's not trying for that. #ang-arch/2 is his variable name (albeit a complicated one). #ang-arch / 2 is invalid syntax and would cause an error. DTR is called in the third line of the second defun.

I didn't see anything wrong with DTR and it worked fine when I tried it. Why are you convinced the pi is still causing the problem. What's PI90?

When I am running the debug function in Vlisp. It runs to the point in this functions and stops.

  (defun calculus ()
  (setq ang-arch 24)
  (setq #ang-arch (dtr ang-arch))
  (setq #ang-arch / 2 (/ #ang-arch 2))
  (setq left-ang (+ PI90 #ang-arch / 2))
  (setq right-ang (- PI90 #ang-arch / 2))
;;(4C-cal)
;;(3c-cal)  
) ;_end defun (calculus)

It stops here:

 (setq left-ang (+ PI90 #ang-arch / 2))

I am just taking a guess at it.

But when I try the routine out. It goes to the third question (Give the brick length) and it gives me a (bad argument type: numberp: nil) when I input a number.


Thank you,

Brad

[scwegner]

It stops here:

 (setq left-ang (+ PI90 #ang-arch / 2))

I am just taking a guess at it.

But when I try the routine out. It goes to the third question (Give the brick length) and it gives me a (bad argument type: numberp: nil) when I input a number.

Exactly what I thought. You caught me while I was editing my last post but I'll answer here too. The problem is with PI90. I don't see it being defined anywhere and certainly not before you get to it in the program.

Oh, and get rid of those spaces you just added to #ang-arch/2

[BCrouse]

Exactly what I thought. You caught me while I was editing my last post but I'll answer here too. The problem is with PI90. I don't see it being defined anywhere and certainly not before you get to it in the program.

Oh, and get rid of those spaces you just added to #ang-arch/2

Second, is there a method to the madness as far as the order of your subroutines? I couldn't see one and with so many, it's helpful to have them sorted somehow.

I did not write this routine. Someone elso wrote this for bnc_designs. I am trying to see if I can get it to work. What would be the best way to get this routine to work in order? Would it need to be rewritten? If so, this routine is to complicated for me to do.

Thank you,

Brad