Need help verifying file exists

[stephen.coff]

Could anyone assist me please.
I am not sure what I am doing wrong ?

Below is the first part of my routine and not all is relevant. I am stuck with the last part, trying to check if the file already exists to see if I need to replace the file "y" or not.

  (setq drawprefix (getvar "dwgprefix"))
  (setq drawname (getvar "dwgname"))
  (setq bldlvl
  (strcase (getstring "\nBuilding Level ie: B1, G, L1 or R? ")
  )
  )
  (setq currentdirectory
  (strcat (getvar "dwgprefix") (getvar "dwgname"))
  )
  (setq newdrawname (strcat "XR-A-" bldlvl))
  (setq num 17)
  (setq strlength (strlen drawprefix))
  (setq newnum (- strlength num))
  (setq ammenddrawprefix1
  (strcat (vl-string-right-trim
     (substr drawprefix newnum strlength)
     drawprefix
   )
   "\\"
  )
  )
  (setq newdirectpath (strcat ammenddrawprefix1 newdrawname))
  (setq check (findfile newdrawname)
  (if (= check newdirctpath) (command "saveas" "r14" newdirectpath "y") (command "saveas" "r14" newdirectpath))

[ Moderator Action = ON ] What are [ CODE ] tags... [ Moderator Action = OFF ]

Would be most great full.
Seems to work when the "If" options are (princ "\n...) rather the (command "saveas" ...)
Not sure, Should I be using the "cond" function ?

regards

stephen

[j.f.moelee]

You forgot an e in your statement.
if (= check newdirEctpath) (command "saveas" "r14" newdirectpath "y") (command "saveas" "r14" newdirectpath))

I am not sure yet if this is The bug, but it IS one.

[j.f.moelee]

I put this code Visual LISP and found one error with closing brackets.
I know that a popular translation of LISP is "Lost In Stupid Parentheses"
but you must check it or else......

(setq check (findfile newdrawname)

In this piece you need 1 more closing bracket.

In addition to my first reply some explanation:
(if (= check newdirctpath) (command "saveas" "r14" newdirectpath "y") (command "saveas" "r14" newdirectpath))

The variable newdirctpath (without a "e") has a value of nil so the if-statement will always do the else (e.g. second) option. When the file exist you get an "error" because AutoCAD ask to confirm the replacing off the old file.

[Avatart]

Below is a snippet of a routine I use to bind in Xrefs, this part of the routine is to check to see if a file exists and set a variable accordingly:

(setq bindpath (strcat (getvar "dwgprefix") "Bind\\"))
(setq savename (strcat bindpath (getvar "dwgname")))
(if (/= (findfile savename) nil) (setq exist 1) (setq exist nil))
(if (/= exist 1)
 (DoBind)
)
(if (= exist 1)
  (progn
 (alert "Bound Version Exists")
 (initget 1 "Yes No")
 (setq boundoverwrite (getkword "Bound Version Exists - Overwrite? (Yes/No)"))
	(if (= boundoverwrite "Yes")
  (DoBind) (DoNotBind)
	  )
	)
  )