Help with while loop, layer lineweight change

[jeff.richards]

I am trying to create a routine that will search through all layers in a drawing and assign a lineweight to each layer based on color. I haven't yet defined a function in the attached sample, but I can get it to change some layer information. Strangely, it changes only every other layer. I am wondering if that is because of the while statement and the relative position of the (setq flag nil) list. I did try moving it inside the loop, but the results were the same.

Any help is greatly appreciated.

Thanks,

[T.Willey]

This is how I would step through a table.

(while (setq Lay (tblnext "layer" (not Lay)))
..... do what you want here
)

This way it will end the loop when you run out of layers.

[jeff.richards]

Tim,

Thanks for the response. Your solution works well, but for some reason, every other layer isn't assigned a width as it should be. I am assuming at this point that it has nothing to do with the loop, but the COND section. Any thoughts?

Thanks again,

[T.Willey]

It's because you use two ' tblnext ' calls per layer.

(setq layer (tblnext "Layer" flag)) nil)
  (setq flag nil)
(setq lname (cdr (assoc 2 (tblnext "Layer")))) ;get the layer name, save to variable

What might be better is after ' layer ' is set, get the entity name of the layer, and assign that to the variable you want, like;

(setq LayData (entget (tblobjname "layer" (cdr (assoc 2 layer)))))

Then use ' LayData ' to change all the things you need.

[jeff.richards]

Tim,

That was it. I just used the layer variable to set the layer name and then it ran like a dream.

Many Thanks,

[T.Willey]

Tim,

That was it. I just used the layer variable to set the layer name and then it ran like a dream.

Many Thanks,

Glad to hear that Jeff. You're welcome.